Re: [Libreoffice] [REVIEW] fix for fd#45401, crash in our inbuild xslt transformation filters

Hi Markus,

thanks for spotting and fixing this. I pushed a fix for that to master
last december and hoped for it to magically move to the 3-5 branch,
which it didn't. Sigh.

http://cgit.freedesktop.org/libreoffice/core/commit/filter/source/xsltfilter/LibXSLTTransformer.cxx?id=80b8744a97502c10b87c2f869c6672f43495be12

I'd also consider that patch safe and relevant for 3-5, because the bug
effectively makes the XSLT unusable.

Regards,

Peter

Am 31.01.12 21:50, schrieb Markus Mohrhard:
> Hey,
>
> this patch fixes a crash in 3-5. We delete the thread while it is
> still running. The patch just adds a Thread::join call to wait till
> the thread is correctly termintated before the thread is deleted.
>
> I think the patch is safe and should be applied to 3-5 and maybe even to 3-5-0.
>
> Regards,
> Markus