Re: [Libreoffice] [PATCH] contour handling for anchored draw objects in writer (fix for bugs 34611 and 45376)

On 30/01/12 22:53, Andreas Schierl wrote:
> Hi, I found out that bugs
>    https://bugs.freedesktop.org/show_bug.cgi?id=34611
>    https://bugs.freedesktop.org/show_bug.cgi?id=45376
> are caused by a missing call to
>     ClrContourCache( pObj );
> in
>     /sw/source/core/layout/pagechg.cxx:
>     void lcl_MoveAllLowerObjs( SwFrm* pFrm, const Point&  rOffset )
> in the
>     else if ( pAnchoredObj->ISA(SwAnchoredDrawObject) )
> case (in the if case, pFlyFrm->NotifyDrawObj() calls ClrContourCache).
>
> The attached patch fixes that problem.
seems like pretty impressive piece of detective work to find that, great 
work!! I've committed the patch to master ( bug doc works fine for me ) 
however since I know precious little about writer ( and in this case 
some layout stuff too ) I cc some writer experts who may suggest some 
alternative solution(s) or change ( or maybe say it is perfect )
Can you confirm your contribution is under the MPL 1.1 / GPLv3+ / 
LGPLv3+ license(s)

Noel