Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hello,

Cppchecks reports this :
core/store/source/storlckb.cxx
74      duplicateBranch style   Found duplicate branches for if and else.

Here are the lines : 
     67 OStoreLockBytes::~OStoreLockBytes (void)
     68 {
     69     if (m_xManager.is())
     70     {
     71         if (m_xNode.is())
     72         {
     73             OStorePageDescriptor aDescr (m_xNode->m_aDescr);
     74             if (m_bWriteable)
     75                 m_xManager->releasePage (aDescr);
     76             else
     77                 m_xManager->releasePage (aDescr);
     78         }
     79     }
     80 }

It's from commit 7c704c78d3c652504c064b4ac7af55a2c1ee49bb 

Could we just remove the if or must something be added ?

Julien.

--
View this message in context: 
http://nabble.documentfoundation.org/Duplicate-branches-for-if-and-else-in-store-source-storlckb-cxx-tp3701331p3701331.html
Sent from the Dev mailing list archive at Nabble.com.

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.