Re: [Libreoffice] [PATCH] fdo#45285 - Use more revealing error message for not allowed sheet names

Hi,

> Hi Albert,
>
> > ... The sheet name must not be a duplicate of an existing name.
>
> Yes.
>
> > ... Further it must be 31 or fewer characters and can not contain the >
> > characters [ ] * ? / \ .
>
> No, AFAIK there is no " <= 31" restriction. And '.' isn't a forbidden
> character, see the source code:
> http://cgit.freedesktop.org/libreoffice/core/tree/sc/source/core/data/document.cxx#n250
>
> But anyway improving this error message would be great! :) I believe that
> most people hate meaningless error messages.
>
> Thanks,
> Ivan

Thanks for the feed-back, Ivan! I have updated the patch accordingly.
/Albert

From 31dd0f0a8c1b280d4958cf75b2090dd2faa2579b Mon Sep 17 00:00:00 2001
From: Albert Thuswaldner <albert.thuswaldner@gmail.com>
Date: Sat, 28 Jan 2012 20:54:09 +0100
Subject: [PATCH] Updated error message for Invalid sheet name

---
 sc/source/ui/src/globstr.src |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sc/source/ui/src/globstr.src b/sc/source/ui/src/globstr.src
index 20ab9aa..6c87a30 100644
--- a/sc/source/ui/src/globstr.src
+++ b/sc/source/ui/src/globstr.src
@@ -687,8 +687,7 @@ Resource RID_GLOBSTR
     };
     String STR_INVALIDTABNAME
     {
-        Text [ en-US ] = "Invalid sheet name." ;
+        Text [ en-US ] = "Invalid sheet name. \nThe sheet name must not be a duplicate of an 
existing name \nand can not contain the characters [ ] * ? / \\ " ;
     };
     String STR_SCENARIO
     {
-- 
1.7.3.4