Re: [Libreoffice] Duplicate expression in sd/source/ui/view/outlview.cxx

Ivan Timofeev <timofeev.i.s -AT- gmail.com>

Sat, 28 Jan 2012 11:55:48 +0400

Hi Julien, 28.01.2012 11:12, julien2412 пишет:

So either the duplicated part (obviously "mpOutliner != NULL") could be
simply removed
or perhaps the author thought about this  :
  mpOutlineViewShell != NULL

mpOutlineViewShell is initialized and dereferenced in the ctor, and

keeps its value all the time. Thus it can't be NULL. (I'd like to have

references instead of pointers in such cases. :)

It seems that the author of the commit just didn't notice the first

"mpOutliner != NULL".

Hope that helps, Ivan

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.