Re: [Libreoffice] [REVIEW][3-5][3-5-0] Fix for formula reference chain breakage during pivot table update

On Fri, 2012-01-27 at 00:23 +0100, Eike Rathke wrote:
> Hi Kohei,
>
> On Friday, 2012-01-27 00:03:29 +0100, Eike Rathke wrote:
>
> > > Then the second part is in ScDPOutput::Output(), where the old content
> > > gets removed before writing out a new one.  The thing is, this method
> > > only gets called from ScDPObject::Output(), and that method already
> > > deletes the old content which makes the removal code in ScDPOutput
> > > unnecessary.  So, when updating or refreshing the pivot table output,
> > > calc was essentially deleting the range twice.
> >
> > That's indeed unnecessary.
>
> Or is it? Before that, CalcSizes() is called that modifies nTabEndCol
> and nTabEndRow that are passed to pDoc->DeleteAreaTab(), didn't check if
> that actually may grow the area that was cleared before.

I at least did test cases where the pivot table size changes after
editing, and it didn't leave any traces in those scenarios.

If in doubt, it'll be safer to leave it in for 3.5.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc