On 26/01/12 16:21, Cedric Bosdonnat wrote:
Hi all,
Could someone review and cherry-pick this commit to -3-5, -3-5-0 and
-3-4?
http://cgit.freedesktop.org/libreoffice/core/commit/?id=5e51960dede5015b862df05b7b16f02884647889
your fix looks good to me, except for the line:
sal_uInt16 nMaxDstId = *aIds.end();
if i'm reading this right, then aIds could be empty here, if the source
document has seq field references, and the target document has no seq
field references but note references.
suggest to wrap an "if (!aIds.empty())" around the whole block?
no need to adjust anything in that case, right?
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.