Re: [Libreoffice] [REVIEW] fix for fdo#43462, ScTableSheetObj::findAll returns always the whole sheet if something is found

Kohei Yoshida <kohei.yoshida -AT- suse.com>
Wed, 25 Jan 2012 15:47:48 -0500

On Wed, 2012-01-25 at 21:19 +0100, Markus Mohrhard wrote:

Hey,

It would be great if we could backport
http://cgit.freedesktop.org/libreoffice/core/commit/?id=b0af6fd51c644827593f3d69c46dc8074dca0ee3
to 3-5 and 3-5-0.

The patch is extremelly safe and just removes the unnecessary and
wrong usage of ScMarkData in this case. rMark is passed as const
reference now and the range containing the result is in
aMatchedRanges.


I concur.  Pushed to the -3-5 branch with my sign-off.

We'll need two more sign-off's to put this into 3-5-0.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc

Context

[Libreoffice] [REVIEW] fix for fdo#43462, ScTableSheetObj::findAll returns always the whole sheet if something is found · Markus Mohrhard
- Re: [Libreoffice] [REVIEW] fix for fdo#43462, ScTableSheetObj::findAll returns always the whole sheet if something is found · Kohei Yoshida
  - Re: [Libreoffice] [REVIEW] fix for fdo#43462, ScTableSheetObj::findAll returns always the whole sheet if something is found · Eike Rathke
    - [Libreoffice] [REVIEWED] fix for fdo#43462, ScTableSheetObj::findAll returns always the whole sheet if something is found · Michael Meeks

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.