Re: [Libreoffice] [REVIEW][3-5] Fix pivot table's date and number grouping

Eike Rathke <erack -AT- redhat.com>
Tue, 24 Jan 2012 12:24:08 +0100

Hi,

On Tuesday, 2012-01-24 11:42:57 +0100, Markus Mohrhard wrote:

 Did you check with libreoffice 3-5? I think that eike's work for date
patterns is missing in 3-5


Yes, that's only on master.

so that this patch does reopen the bug we
discussed on IRC. At least your unit test fails and I think we should
check that before adding the patch to 3-5.


Relying on date patterns sounds very fragile, they vary between locales
and may change at any time.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

Attachment: pgpD6e_nRivg_.pgp
Description: PGP signature

Context

[Libreoffice] [REVIEW][3-5] Fix pivot table's date and number grouping · Kohei Yoshida
- Re: [Libreoffice] [REVIEW][3-5] Fix pivot table's date and number grouping · Markus Mohrhard
  - Re: [Libreoffice] [REVIEW][3-5] Fix pivot table's date and number grouping · Eike Rathke
    - Re: [Libreoffice] [REVIEW][3-5] Fix pivot table's date and number grouping · Kohei Yoshida

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.