Re: [Libreoffice] [PATCH][PUSHED] Replace ENSURE_OR_* macros with regular code.

Marcel Metz <mmetz -AT- adrian-broher.net>
Tue, 24 Jan 2012 10:43:28 +0100

Hello Stephan,

On 24.01.2012 09:30, Stephan Bergmann wrote:

However, I have another question:  I notice that, while most
occurrences  are replaced with SAL_WARN, some were left as OSL_ENSURE
(which I changed to SAL_WARN; one missed a comma, anyway) and some
are changed to SAL_INFO.  Was there some rationale for that?


No, unfortunately none aside from my sloppiness. Even after reviewing it
twice it does seem like I don't get it right. :/
Thanks for your review Stephan.

regards Marcel

Context

[Libreoffice] [PATCH] Replace ENSURE_OR_* macros with regular code. · Marcel Metz
- Re: [Libreoffice] [PATCH] Replace ENSURE_OR_* macros with regular code. · Muthu Subramanian K
  - Re: [Libreoffice] [PATCH] Replace ENSURE_OR_* macros with regular code. · Marcel Metz
    - Re: [Libreoffice] [PATCH] Replace ENSURE_OR_* macros with regular code. · Muthu Subramanian K
    - Re: [Libreoffice] [PATCH][PUSHED] Replace ENSURE_OR_* macros with regular code. · Stephan Bergmann
      - Re: [Libreoffice] [PATCH][PUSHED] Replace ENSURE_OR_* macros with regular code. · Marcel Metz

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.