Re: [Libreoffice] [REVIEW][3-5] let postgresql-sdbc find its dependencies

On Mon, Jan 23, 2012 at 03:21:30PM +0100, Stephan Bergmann wrote:

> * <https://bugs.freedesktop.org/show_bug.cgi?id=45058>
> "postgresql-sdbc doesn't work on LO 3.5RC1 win32"

> * <https://bugs.freedesktop.org/show_bug.cgi?id=45090>
> "PostgreSQL-SDBC fails to load on Unix / official binaries: missing
> libldap50.so"

> (of which neither is currently attached to
> <https://bugs.freedesktop.org/show_bug.cgi?id=37361> "LibreOffice
> 3.5 most annoying bugs," however) can (only) be solved by changing
> the postgresql-sdbc functionality from a bundled extension into a
> proper (optional) part of LO.

> The attached
> 0001-Changed-postgresql-sdbc-from-bundled-oxt-to-proper-o.patch
> (against recent libreoffice-3-5) does just that.  It builds fine on
> Linux and produces installation sets that properly contain the
> various files for the postgresql-sdbc functionality.

"only fixed" is exaggerated. Maybe "most cleanly fixed".

fdo#45058: I'm not convinced it is a DLL loading problem, but future
tests will tell us. I'm not convinced it isn't either.

fdo#45090: we could also set LD_LIBRARY_PATH in soffice shell
wrapper, like we do in the *BSD case, or copy the DLL into the .oxt
file.

> Whether the functionality actually works there however is not clear
> to me, as I have no recipe how to test it.

I'm working on that. Doing a recompile with your patch applied.

> Feel free to review for inclusion in LO 3.5.

I don't see anything very wrong on the patch, but this late in the
development cycle, I'd like someone else than me to review/approve it.

I notice that this makes the PostgreSQL-SDBC code optional to
*install*, but not optional to *compile*. Are we OK with that?

-- 
Lionel