Re: [Libreoffice] [PATCH] Remove unused code

Hi Michael,

On Friday, 2012-01-20 21:57:25 +0100, Michael Stahl wrote:

> > -VclEventListeners2::~VclEventListeners2()
> > -{
> > -}
>
> i'm not sure this is right; if a destructor of a class is unused, but
> its other methods are used, then that usually indicates a memory leak:
> the destructor is never called because all instances are leaked.

Yup.. given that we have

class VclEventListeners2 : public vcl::DeletionNotifier
{
    ~VclEventListeners2();
}

maybe it's sufficient to make the dtor virtual if there's a delete
baseclasspointer somewhere?

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

Attachment: pgpPvtK7DgvhN.pgp
Description: PGP signature