On Sun, 2012-01-15 at 21:52 -0500, Marc-André Laverdière wrote:
Hello list,
Since I went a bit beyond unusedcode.easy, I prefer to ask review on this one :)
I assume you are talking about the change in SVGExport? It all looks
reasonable to me. If the push method is not used, then that implies
that the clip container is always empty. With that, you can remove a
little more code like you did in your patch.
BTW, we ask all patch submitters to put [PATCH] in the subject line, or
prospective patch reviewers may overlook your patch.[1]
Also, I didn't apply your changes in the datetime files in tools. Looks
like someone else has got to it first.
Thanks,
Kohei
[1] http://wiki.documentfoundation.org/Development/Patch_Handling_Guideline
--
Kohei Yoshida, LibreOffice hacker, Calc
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.