Re: [Libreoffice] [PATCH] Bug 33794 - The "Open..." button of the initial screen needs more room for localization fdo#33794

Hello,

13.01.2012 18:15, Tomcsik Bence Tibor пишет:
> Hi,
>
> Bug 33794 solved.

IMHO it's better to pass some additional parameter to the layoutButton 
function ( e.g. int i_nExtraWidth = 0 ) and change:

    nTextWidth += maButtonImageSize.Width() + 8; // add some fuzz to be 
on the safe side

to:

    nTextWidth += maButtonImageSize.Width() + 8 + i_nExtraWidth;

; then use i_nExtraWidth = 18 (as you suggested in the patch: 26 - 8 = 
18) for the "Open..." button.

What do you think?

Regards,
Ivan