Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Yeah, but given that such a re-design is probably a long way off, and that other drivers seem are confined to a single-thread, and seem to have acceptable performance, perhaps we should just live with this limitation, and optimise the easy-case?

On 2012-01-13 11:18, Stephan Bergmann wrote:
On 01/13/2012 09:59 AM, Noel Grandin wrote:

Surely now that it's confined to a single thread, it can just call
AttachThread() once at startup, and never need to call DetachThread() ?

Yes, one could improve it further based on the fact that it is confied now (it also internally uses some mutices that could go now). But: "However, a better fix would still be to redesign the code so that it does not call Attach/DetachCurrentThread so frequently [and confinement to the thread-affine apartment can be undone again.]", <http://cgit.freedesktop.org/libreoffice/core/tree/connectivity/source/drivers/jdbc/jservices.cxx?id=bb59742bcf4883af5876a2ffadcc4a689e414b60#n95>.

Stephan


Disclaimer: http://www.peralex.com/disclaimer.html



Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.