Re: [Libreoffice] [PATCH] If there's no java, don't do the java stuff

On Mon, Jan 09, 2012 at 01:04:20PM +0100, Christophe Strobbe wrote:
> Hi Korrawit,
>
> At 18:24 8-1-2012, Korrawit Pruegsanusak wrote:
> > Hello all,
> >
> > This attached patch fixes build on windows / cygwin.
> >
> > I'm building --without-java, and it breaks because not found
> > "java_uno_accessbridge", which seems java-related.
>
> I noticed on the mailing list that David Tardon has already pushed
> your patch, but I'm still curious to know: did you have the Java
> Access Bridge [1] installed when you tested this patch (I assume you
> didn't have it because the build broke)?
>
> [1] <http://www.oracle.com/technetwork/java/javase/tech/index-jsp-136191.html>

java_uno_accessbridge.jar is one of two jars we build in module
accessibility (only for Windows).

> > So, I add a check whether we have "SOLAR_JAVA" before doing this thing.
>
> So java_uno_accessbridge is only added when "SOLAR_JAVA" is set to
> "TRUE", which AFAICT is something that happens at compile time.

Yes, because when SOLAR_JAVA is not set, it might mean there is not any
Java compiler avaliable, so we can hardly build any jars :)

D.