Re: [Libreoffice] npshell build / functionality [was: Re: Tinderbox failure, last success: 2011-12-05 19:05:50]

On 10/01/12 09:52, Jan Holesovsky wrote:
> Hi,
>
> On 2012-01-10 at 04:49 +0000, nthiebaud@gmail.com wrote:
>
> >   Box name: Win-x86@9-Voreppe Win32
> >   Machine: CYGWIN_NT-6.1-WOW64 VOREPPELIBO 1.7.9(0.237/5/3) 2011-03-29 10:10 i686 Cygwin
> [...]
> > [ build CXX ] extensions/source/nsplugin/source/npshell.cxx
> > d:\master\extensions\source\nsplugin\source\npshell.hxx(81) : error C2143: syntax error : 
> > missing ';' before '*'
> > d:\master\extensions\source\nsplugin\source\npshell.hxx(81) : error C4430: missing type 
> > specifier - int assumed. Note: C++ does not support default-int
>
> I have fixed this:
>
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=23b1ba968f0e092d78e98bebcfcf662b8442d711
>
> and restarted the build.
>
> Probably I broke some visibility-related behavior in there; it built for
> me on Linux, but double-checking that the needed symbols are there on
> your architecture would be appreciated.

i had introduced the DLLPUBLIC in
a12ea5554bcd9ddc7d7f1915ed67f0dd86e062b6 to get rid of some weird .def
file that seemed to export those symbols on windows.

i suppose if these aren't exported then the plugin won't work, since
probably these are all looked up via dlopen or whatever it's Windows
equivalent is.

on Linux with your change i get only 3 symbols from that file exported,
and the others not.  perhaps MSVC complained that the
SAL_DLLPUBLIC_EXPORT is just in the wrong position or something, can you
investigate?