Re: [Libreoffice] [PATCH] [PUSHED] msvc doesn't allow dll interface in both class and functions

Stephan Bergmann <sbergman -AT- redhat.com>
Mon, 09 Jan 2012 11:12:08 +0100

On 01/08/2012 06:20 PM, Korrawit Pruegsanusak wrote:

IMHO, the problem is caused by part of the commit [1]
Seems msvc doesn't allow us to have SAL_DLLPUBLIC_EXPORT in both class
and functions definition. It throws compiler error C2487 [2]

So, I tried to fix with 2 methods:
1. Remove dll interface from functions definition, now the whole class
has dll interface
2. Remove dll interface from class definition, and only some functions
has dll interface
which I attached both patches.

Fixed in a third way now,<http://cgit.freedesktop.org/libreoffice/core/commit/?id=2fa19ed7e407188d6af028aad19a2598454959a8>,reducing the set of exported symbols to just what is needed byextensions/qa/update/test_update.cxx.


Stephan

Context

[Libreoffice] [PATCH] msvc doesn't allow dll interface in both class and functions · Korrawit Pruegsanusak
- Re: [Libreoffice] [PATCH] [PUSHED] msvc doesn't allow dll interface in both class and functions · Stephan Bergmann
  - Re: [Libreoffice] [PATCH] [PUSHED] msvc doesn't allow dll interface in both class and functions · Korrawit Pruegsanusak

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.