Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hello,

Cppcheck report tells this :
1474    duplicateBranch style   Found duplicate branches for if and else
for l10ntools/source/export.cxx


Even if this seems easy, perhaps it could be something else than just
"rText" here.

diff --git a/l10ntools/source/export.cxx b/l10ntools/source/export.cxx
index bd1fbfb..fbed184 100644
--- a/l10ntools/source/export.cxx
+++ b/l10ntools/source/export.cxx
@@ -1475,7 +1475,7 @@ void Export::InsertListEntry( const ByteString &rText,
const ByteString &rLine )
             (*pCurEntry)[ SOURCE_LANGUAGE ] = rLine;
         }
         else
-            (*pCurEntry)[ SOURCE_LANGUAGE ] = rLine;
+            (*pCurEntry)[ SOURCE_LANGUAGE ] = rText;
 
         pList->NewSourceLanguageListEntry();
     }

Your opinion ?

Julien
PS : if ok, I can of course commit and push on master 

--
View this message in context: 
http://nabble.documentfoundation.org/REVIEW-Easy-patch-on-l10ntools-tp3617480p3617480.html
Sent from the Dev mailing list archive at Nabble.com.

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.