Re: [Libreoffice] [PUSHED] Re: minor problem with Insert -> indexes and tables dialog

On Tue, Dec 27, 2011 at 4:50 PM, Jan Holesovsky <kendy@suse.cz> wrote:

> Hi Ivan,
>
> Ivan Timofeev píše v Út 27. 12. 2011 v 17:47 +0400:
>
> > SwMultiTOXTabDialog is derived from TabDialog. TabDialog uses the weird
> > automatic arrangement code, see vcl/source/window/tabdlg.cxx, method
> > TabDialog::ImplPosControls(). After executing this method all controls
> > below a TabControl will have the same width! And this width is
> > calculated as max width of text of control plus some constant
> > IMPL_EXTRA_BUTTON_WIDTH. For buttons this works. For checkbox this fails.
>
> Great catch! :-)
>
> > So what to do?
> >
> > 1. dirty hack: increase IMPL_EXTRA_BUTTON_WIDTH :)
> > 2. consider type of controls and use an appropriate method to determine
> > the width.
> > 3. smth else?
>
> Based on your nice analysis, I pushed this:
>
>
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=f29c4dca4a451d28d5fef06c966725636e542eeb
>
> [both to master and libreoffice-3-5]

Thank you guys... it's fun to see things going forward fast with
collaboration.

Kaplan