Re: [Libreoffice] [PATCH] Fix fdo#39639 [EasyHack] Fix duplicate longname IDs

Victor Lee <konya.vic -AT- gmail.com>

Sun, 25 Dec 2011 01:41:59 +0900

Hi Kendy, I've reformatted the patch. The reason for deleting these IDs is stated here: https://bugs.freedesktop.org/show_bug.cgi?id=39639 Sorry for the late reply, and thank you for the advice! This is my first EasyHack. Victor Lee On Wed, Dec 21, 2011 at 12:51 AM, Jan Holesovsky <kendy@suse.cz> wrote:

Hi Victor,

On 2011-12-20 at 17:34 +0900, Victor Lee wrote:

the attached patch simply removes duplicated and unused IDs in
BackgroundsDialog.


Thank you for the patch, and welcome to LibreOffice! :-)

Just wanted to ask you how did you find these?  I mean, it seems to me
that "HID:WIZARDS_HID_BG_BTN_IMG12" is not used either [or is it?], so
why exactly do you remove only IMG13 and above, and not all the
HID:WIZARDS_HID_BG_BTN_IMG*?

Regarding the patch itself, it would be great if you can use the output
of git format-patch as described here:

http://wiki.documentfoundation.org/Development#Preparing_patches

Thank you a lot,
Kendy

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.