Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460 Part XIV getLength() to isEmpty()

Ivan Timofeev <timofeev.i.s -AT- gmail.com>

Fri, 23 Dec 2011 22:13:38 +0400

Hi Gustavo, 23.12.2011 21:21, Gustavo Pacheco пишет:

Hi!

Partial fix for Easy Hack FDO43460 (part XIV) for review. Mentoring by
Olivier Hallot (thanks for the tips Olivier!).

Part XVI
Modules drawinglayer, dtrans and editeng

Looks nice for me, but

- if (aLocale.Language.getLength() ||

aLocale.Country.getLength())

+ if (!(aLocale.Language.isEmpty() || aLocale.Country.isEmpty()))

is wrong - (!A || !B) => !(A && B), but since I personally don't like

negators outside a compound condition, I changed it to the first variant.

Context

[Libreoffice] [PATCH] Fix for fdo43460 Part XIV getLength() to isEmpty() · Gustavo Pacheco

Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460 Part XIV getLength() to isEmpty() · Ivan Timofeev

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.