Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index 

Hi August,

On Mon, Dec 19, 2011 at 08:11:42PM -0800, August   Sodora <augsod@kemper.freedesktop.org> wrote:

 vcl/inc/vcl/field.hxx                           |    9 --
 vcl/source/control/field2.cxx                   |   92 ------------------------
 writerfilter/inc/resourcemodel/TagLogger.hxx    |    5 -
 writerfilter/source/resourcemodel/TagLogger.cxx |   53 -------------
 4 files changed, 159 deletions(-)


Please avoid such commits in the future, what you removed are methods
necessary for the XML dump writerfilter creates when built using
dbglevel=2.

I've fixed it with commit acfdec468d54d44f94ca6752bbbfbdab07ef9a0c - in
fact the best is to properly find the user of the method, see how it is
defined (DEBUG_DOMAINMAPPER, DEBUG_RESOLVE, etc) and add ifdef guards
around those "unused" methods.

Thanks.

Attachment: pgp5iyqmW4dqM.pgp
Description: PGP signature

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.