Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Matteo Casalin wrote:
From my understanding, if we remove these 2 calls that set te 
COMPRESSMODE_FULL flag then there is no reason to keep the code that 
depend on that, unless the svstream acquires the flag from the stream 
itself or that it's set by calling the set function with a "magic 
number" instead of the #define.

Quite. Now really looking into what vcl/source/gdi/gdimtf.cxx does,
the nStmCompressMode is *read* from the input, but then happily
ignored - so the code, as it is, will already balk on thusly written
files. The only other use I see is internal, i.e. within the same
running LibO instance - so yeah, go & kill this off! :)

Cheers,

-- Thorsten

Attachment: pgpBmLlSm0EIf.pgp
Description: PGP signature


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.