Re: [Libreoffice] [PATCH] Fix for fdo43460 Part VII getLength() to isEmpty()

Ivan Timofeev <timofeev.i.s -AT- gmail.com>
Tue, 13 Dec 2011 12:04:27 +0400

Hi Olivier,

13.12.2011 05:08, Olivier Hallot пишет:

Please find attached a partial fix for Easy Hack FDO43460

Part VII
Module
comphelper


Not sure whether this improves readability:

+++ b/comphelper/source/misc/storagehelper.cxx

@@ -522,7 +522,7 @@ sal_Bool OStorageHelper::PathHasSegment( const::rtl::OUString& aPath, const ::r

     const sal_Int32 nPathLen = aPath.getLength();
     const sal_Int32 nSegLen = aSegment.getLength();

-    if ( nSegLen && nPathLen >= nSegLen )
+    if ( !aSegment.isEmpty() && nPathLen >= nSegLen )
     {
         ::rtl::OUString aEndSegment( RTL_CONSTASCII_USTRINGPARAM( "/" ) );
         aEndSegment += aSegment;

and in the script this is described as false positive. So I dropped thischange and pushed:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=00a67c0f9056729695e6004707d64b448756fa6f

This easy hack is not so easy due to its enormous monotony. ;) Thank youfor doing this!


Ivan

Context

[Libreoffice] [PATCH] Fix for fdo43460 Part VII getLength() to isEmpty() · Olivier Hallot
- Re: [Libreoffice] [PATCH] Fix for fdo43460 Part VII getLength() to isEmpty() · Ivan Timofeev
  - Re: [Libreoffice] [PATCH] Fix for fdo43460 Part VII getLength() to isEmpty() · Olivier Hallot
    - Re: [Libreoffice] [PATCH] Fix for fdo43460 Part VII getLength() to isEmpty() · Stephan Bergmann
- Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460 Part VII getLength() to isEmpty() · Ivan Timofeev

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.