Re: [Libreoffice] [PUSHED][PATCH 1/4] fdo38832 Replace ImplAccelTable with std::map

Ivan Timofeev <timofeev.i.s -AT- gmail.com>
Mon, 12 Dec 2011 20:10:48 +0400

12.12.2011 20:05, Caolán McNamara пишет:

On Sat, 2011-12-10 at 19:23 +0100, Marcel Metz wrote:

Hello lo-devs,

This patch series replaces some DECLARE_TABLE macros with
the std::map equivalent.


Looks good to me. Thanks for this, pushed now.


Hmm... looking at this I think that

- else if ( !mpData->maKeyTable.Insert( nCode, pEntry ) )

+ else if ( mpData->maKeyMap.insert( std::make_pair( nCode, pEntry )).second )


must be

- else if ( !mpData->maKeyTable.Insert( nCode, pEntry ) )

+ else if ( !mpData->maKeyMap.insert( std::make_pair( nCode, pEntry )).second )


i.e. ! is missed in replacement.

Regards,
Ivan

Context

[Libreoffice] [PATCH 1/4] fdo38832 Replace ImplAccelTable with std::map · Marcel Metz
- [Libreoffice] [PUSHED][PATCH 1/4] fdo38832 Replace ImplAccelTable with std::map · Caolán McNamara
  - Re: [Libreoffice] [PUSHED][PATCH 1/4] fdo38832 Replace ImplAccelTable with std::map · Ivan Timofeev
    - Re: [Libreoffice] [PUSHED][PATCH 1/4] fdo38832 Replace ImplAccelTable with std::map · Caolán McNamara
  - Re: [Libreoffice] [PUSHED][PATCH 1/4] fdo38832 Replace ImplAccelTable with std::map · Caolán McNamara

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.