[Libreoffice] [PATCH] configure.in examples: options shouldn't have quote

Korrawit Pruegsanusak <detective.conan.1412 -AT- gmail.com>
Sun, 11 Dec 2011 11:47:02 +0700

Hello all,

I've attached two cosmetic patches of configure.in.
First patch fixes an example in AS_HELP_STRING. The configure options
shouldn't be passed with quotation marks, as described in commit
message.
But I'm not sure whether it's correct or apply to all platform. So, I
sent it here for a review.

Second patch is just a trivial change: --with-theme is without "s".

Last but not least, I've noticed that there are two themes, classic
and industrial, that described in AS_HELP_STRING (see context in first
patch) but not detected while checking (see context in second patch).
That is, if user pass e.g. --with-theme=classic, it'll fail. So, do we
really support classic and industrial themes? I've found them listed
on ooo_custom_images [1], but I'm not sure if it's relevant.

[1] http://opengrok.libreoffice.org/xref/core/ooo_custom_images/

Please feel free to comment :)
Best Regards,
-- 
Korrawit Pruegsanusak

Attachment: 0001-These-options-shouldn-t-be-passed-with-quotation-mar.patch
Description: Binary data

Attachment: 0002-with-theme-is-without-trailing-s.patch
Description: Binary data

Context

[Libreoffice] [PATCH] configure.in examples: options shouldn't have quote · Korrawit Pruegsanusak
- [Libreoffice] [PARTIAL-PUSHED] [PATCH] configure.in examples: options shouldn't have quote · Lionel Elie Mamane
  - Re: [Libreoffice] [PARTIAL-PUSHED] [PATCH] configure.in examples: options shouldn't have quote · Korrawit Pruegsanusak
    - Re: [Libreoffice] [PARTIAL-PUSHED] [PATCH] configure.in examples: options shouldn't have quote · Lionel Elie Mamane

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.