Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460, Part III, getLength to isEmpty

Ivan Timofeev <timofeev.i.s -AT- gmail.com>

Sat, 10 Dec 2011 21:24:15 +0400

10.12.2011 20:34, Olivier Hallot пишет:

Please find attached a partial fix for Easy Hack FDO43460,

Part III
Module basic

Pushed, thank you! :) May I suggest you to remove unnecessary parentheses in addition? i.e sal_Bool bOldPassword = ( !OldPassword.isEmpty() ); can be sal_Bool bOldPassword = !OldPassword.isEmpty(); and thus more readable (at least to me) :) Regards, Ivan

Context

[Libreoffice] [PATCH] Fix for fdo43460, Part III, getLength to isEmpty · Olivier Hallot

Re: [Libreoffice] [PUSHED][PATCH] Fix for fdo43460, Part III, getLength to isEmpty · Ivan Timofeev

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.