Re: [Libreoffice] [PATCH] Fix for fdo43460, Part I, getLength to isEmpty

Stephan Bergmann <sbergman -AT- redhat.com>
Fri, 09 Dec 2011 19:07:17 +0100

On 12/09/2011 05:14 PM, Olivier Hallot wrote:

diff --git a/accessibility/source/standard/vclxaccessiblebox.cxx 
b/accessibility/source/standard/vclxaccessiblebox.cxx
index e868403..82a7677 100644
--- a/accessibility/source/standard/vclxaccessiblebox.cxx
+++ b/accessibility/source/standard/vclxaccessiblebox.cxx
@@ -156,7 +156,7 @@ void VCLXAccessibleBox::ProcessWindowEvent (const VclWindowEvent& rVclWindowEven
                 if ( xText.is() )
                 {
                     ::rtl::OUString sText = xText->getSelectedText();
-                    if ( !sText.getLength() )
+                    if ( !sText.isEmpty() )
                         sText = xText->getText();
                     pList->UpdateSelection (sText);
                 }

This and a few more that follow invert the logic -- !sText.getLength()<=> sText.getLength() == 0 <=> sText.isEmpty(). I'll fix those and pushlater today.


Thanks a lot,
Stephan

Context

[Libreoffice] [PATCH] Fix for fdo43460, Part I, getLength to isEmpty · Olivier Hallot
- Re: [Libreoffice] [PATCH] Fix for fdo43460, Part I, getLength to isEmpty · Stephan Bergmann
  - Re: [Libreoffice] [PATCH] Fix for fdo43460, Part I, getLength to isEmpty · Olivier Hallot
  - [Libreoffice] [PUSHED] Fix for fdo43460, Part I, getLength to isEmpty · Michael Meeks
    - Re: [Libreoffice] [PUSHED] Fix for fdo43460, Part I, getLength to isEmpty · Olivier Hallot
      - Re: [Libreoffice] [PUSHED] Fix for fdo43460, Part I, getLength to isEmpty · Stephan Bergmann

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.