Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


08.12.2011 23:36, Ivan Timofeev пишет:
Hi there!

Please review
http://cgit.freedesktop.org/libreoffice/core/commit/?id=dc61ebdc93a777f4f41c1ae837bdb6098ecffcce

and push to 3-4 if the commit is ok for you.

It seems, due to wrong condition (using & instead of ==) the code casted
SwCntntNode to SwTxtNode, but the SwCntntNode is a base class of the
SwTxtNode.

Thanks,
Ivan

Oh no, wait, I was getting all mixed up :(
This is not a fix for the mentioned bug, the proper fix was
http://cgit.freedesktop.org/libreoffice/core/commit/?id=3524727db0f3cfecf3a47046795c527808c10c3e
which is now backported to 3-4.

Heh, excuse my having done so! I tested the bug with master and there was a crash, but after my patch there was not. Then I lost my sanity and went wrong way...

Sorry once again,
Ivan

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.