Re: [Libreoffice] [PATCH 05/11] Replace SmNodeStack with std::stack< SmNode* >

Eike Rathke <erack -AT- redhat.com>
Wed, 7 Dec 2011 14:34:02 +0100

Hi,

On Wednesday, 2011-12-07 00:28:11 +0100, Stephan Bergmann wrote:

i.e., at SmNode *pNode = m_aNodeStack.top() in
SmParser::Expression(), where m_aNodeStack is empty.  It *looks* to
me that the following happens:  The stack is rightfully empty, but
the old implementation of tools' stack Pop() always returned null in
that case, and the code in SmParser::Expression() relies on that --

<http://cgit.freedesktop.org/libreoffice/core/commit/?id=b419bb21a76c48dda9f9a6ef6182b98e03358176>
lets the test succeed, but who knows which other code depended on
this magnificent misfeature of the old stack implementation, too...


I'm inspecting that and will fix.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

Attachment: pgptkT7b0wX1d.pgp
Description: PGP signature

Context

[Libreoffice] [PATCH 05/11] Replace SmNodeStack with std::stack< SmNode* > · Marcel Metz
- Re: [Libreoffice] [PATCH 05/11] Replace SmNodeStack with std::stack< SmNode* > · Stephan Bergmann
  - Re: [Libreoffice] [PATCH 05/11] Replace SmNodeStack with std::stack< SmNode* > · Eike Rathke
    - Re: [Libreoffice] [PATCH 05/11] Replace SmNodeStack with std::stack< SmNode* > · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.