[Libreoffice] [REVIEW][PATCH] crash releaseTimer on NULL mpPresTimer

Caolán McNamara <caolanm -AT- redhat.com>

Tue, 06 Dec 2011 23:10:37 +0000

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d57887eaad534ca51fc4975918fab66b2f93633d Reproducer at https://bugzilla.redhat.com/show_bug.cgi?id=759647 I see that the mpPresTimer in slideshow is reset when dispose is called. However a scopeGuard can still try and call releaseTimer on that mpPresTimer which was disposed since it the guard ctored. The boost::cref that scopeGuard takes doesn't increment the shared_ptr, its effectively just a weak reference. Fix looks right to me anyway ? Anyone know different, and if not is it worth cherry-picking for 3-5 ? C.

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.