Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


This patch improve the comments related to checkmark mirroring: it seems to be needed to compensate the lower level mirroring performed by a device with mirrored graphics. Please verify that I understood correctly the code (can graphics really be mirrored at a lower level?) and take into account that, according to RTL people [1], checkmarks are drawn the same in LTR/RTL languages.

Matteo

[1] Lior Kaplan and Khaled Hosny in the thread "Remember the RTL interface", dated 11/29/2011.
From b94d39b77efb96d20a94292f4e842bdb87223ae4 Mon Sep 17 00:00:00 2001
From: Matteo Casalin <matteo.casalin@poste.it>
Date: Sun, 4 Dec 2011 23:55:56 +0100
Subject: [PATCH 2/2] DecoView - a more descriptive comment about mirroring
 issues with checkmarks

---
 vcl/source/window/decoview.cxx |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/vcl/source/window/decoview.cxx b/vcl/source/window/decoview.cxx
index 1958cd6..c249a86 100644
--- a/vcl/source/window/decoview.cxx
+++ b/vcl/source/window/decoview.cxx
@@ -339,6 +339,8 @@ void ImplDrawSymbol( OutputDevice* pDev, Rectangle nRect, const SymbolType eType
                 // #106953# never mirror checkmarks
                 if ( pDev->ImplHasMirroredGraphics() && pDev->IsRTLEnabled() )
                 {
+                    // Draw a mirrored checkmark so that it looks "normal" in a
+                    // mirrored graphics device (double mirroring!)
                     pDev->DrawLine( Point( nRect.Right(), nRect.Bottom()-n3 ),
                                     Point( nRect.Right()-n3, nRect.Bottom() ) );
                     pDev->DrawLine( Point( nRect.Right()-n3, nRect.Bottom() ),
-- 
1.7.5.4


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.