Hi Thorsten, On Mon, Nov 28, 2011 at 11:57:04AM +0100, Thorsten Behrens wrote:
Khaled Hosny wrote:This patch removes the "reasonable default" value of mnMinKashida which makes no sense at all; either the font have a Kashida glyph and mnMinKashida is set to its width or it doesn't and mnMinKashida is kept 0.Hi Khaled, nice one, pushed - by any chance, do you have a small test document that demonstrates the problem, e.g. with a common font that lacks kashida support? Such that going forward, we don't break this again.
It is really an edge case and I don't think there are fonts with Arabic coverage lacking Kashida, however I'm developing a font where I trick LibreOffice not to do Kashida justification by having a zero width Kashida glyphs (The font is pretty complex with many contextual forms and Kashida justification as implemented in LibreOffice, or other application for that matter, is guaranteed to always produce bad result). Anyway, the font can be obtained from here[1], and I'm attaching a test file that shows this issue. [1] https://sourceforge.net/projects/amiri/files/ Regards, Khaled
Attachment:
lo_no_kashida.odt
Description: application/vnd.oasis.opendocument.text
Attachment:
3.4.png
Description: PNG image
Attachment:
3.5_patch.png
Description: PNG image
Attachment:
signature.asc
Description: Digital signature
