Re: [Libreoffice] [PATCH] [PUSHED] Hide function pointers

On Mon, Nov 28, 2011 at 6:42 PM, Stephan Bergmann <sbergman@redhat.com>wrote:

> On 11/27/2011 08:57 AM, Daisuke Nishino wrote:
>
> > Exposing functioin pointers to outside is not a good practice I think.
> > This patch encapsulates them.
> > Also, since fnLeaveSelect is called from only one location, I eliminated
> > the indirection.
>
> Great, thanks.  Pushed (I simplified the "this->*this->" calls by removing
> the redundant second "this->").
Thanks!


> I do not find your license statement at <
> http://wiki.documentfoundation.org/Development/Developers>, can you add
> it there (I assume you contribute under LGPLv3+/MPL 1.1+)?

Ah, I posted the license statement on Nov 25:

On Fri, Nov 25, 2011 at 2:10 AM, Daisuke Nishino <niboshi000@gmail.com>wrote:

> Lisence:
> All my past and future contributions (including this one) to LibreOffice
> are under LGPLv3+/MPL until further notice.

I thought I don't need to write the statement once I have posted the above.
Should I edit the wiki page, or do I need to write it in every posts?
p.s. I noticed a typo now :(

Thanks,

-- 
Daisuke Nishino