Re: [Libreoffice] [PUSHED] [PATCH] Removing uses of OUString::setCharAt

Thorsten Behrens <thb -AT- documentfoundation.org>
Mon, 28 Nov 2011 15:01:58 +0100

August Sodora wrote:

Tonight I tried to remove some uses of setCharAt so that it can
eventually be removed, and I ran across a few cases that I would like
to get another pair of eyes on. Especially in one particular case, I
added a guard to make sure that the index was within range and I want
to make sure that it is necessary or if something more involved is
required. The patch is attached, and I remembered to add [PATCH] to
the subject this time :)

Hi August,

looks good, pushed now - except for the svl/source/misc/lngmisc.cxx
snippet which was based on older code it seems, dropped that part
entirely.

Thanks a lot, looking forward for more! :)

-- Thorsten

Attachment: pgp17wqPAHgO9.pgp
Description: PGP signature

Context

[Libreoffice] [PATCH] Removing uses of OUString::setCharAt · August Sodora
- Re: [Libreoffice] [PUSHED] [PATCH] Removing uses of OUString::setCharAt · Thorsten Behrens
  - (message not available)
    - Re: [Libreoffice] [PATCH] Removing uses of OUString::setCharAt · August Sodora
      - Re: [Libreoffice] [PUSHED] [PATCH] Removing uses of OUString::setCharAt · Thorsten Behrens

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.