Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hi,

I would like to have the attached two patches applied to libreoffice-3-4.

One is fixing fdo#32112. It is an easy one. LibreOffice creates a
directory but the installer does not know about it. So uninstall
leaves it there. If this directory is created by the installer, then
it will be removed during uninstall, so we can have a clean uninstall.

The second is more complex. It fixes fdo#36677. The bug occurs only
during silent install. During uninstall the installer checks is
LibreOffice is running. However, the check was a bit lame. It tried to
remove a file or folder (depending on Windows version), but Program
Files folder is normally write protected to the user. Silent uninstall
was started with user privileges and uninstall process always failed.
Instead of file manipulation now we check, if there is "soffice.bin"
in the process list.

I tested both patches with LibreOffice 3.4.4 on Windows XP and on
Windows 7. I tested the second one in both scenarios, i.e. when
LibreOffice was running during uninstall and when it was not running.
I pushed the first one to master and I will push the second one there,
too, after some necessary changes.

Thanks,
Andras

Attachment: 0001-create-this-dir-so-uninstall-can-remove-it.patch
Description: Binary data

Attachment: 0001-change-logic-of-IsOfficeRunning-custom-action-fdo-36.patch
Description: Binary data


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.