Re: [Libreoffice] [PATCH] Fix for fdo#42178

On 16/11/11 13:35, Ivan Timofeev wrote:
> Hi there,
>
> I have fixed https://bugs.freedesktop.org/show_bug.cgi?id=42178 :-) ,
> but I think an additional review will not be superfluous, since I am
> still a newbie.
>
> The fact is SwDocShell::GetWrtShell() always returns 0 in page
> preview. And Writer dies due to that in "lcl_GetPrintUIOptions"
> function (sw/source/ui/uno/unotxdoc.cxx).
>
> The second patch makes testing of the first one easier. :-) Because,
> when you press "Cancel" in a print dialog, then make changes to a doc
> and open a print dialog again, you currently will not see any effect.
> Options will not be updated. The patch fixes this.
>
> If someone will approve the patches, I will push them.
these look perfectly find and sensible to me, Cedric would you double check

thanks,
Noel