Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hi,

I have attached a trivial code removal with this mail.
I read the code, (since pUndoSet is set to null in the very constructor,
I guess this if() would never get executed), but, I could have missed
something here - hence the need for review.

Thank you so much!
Muthu Subramanian
diff --git a/svx/source/svdraw/svdundo.cxx b/svx/source/svdraw/svdundo.cxx
index b746813..f094add 100644
--- a/svx/source/svdraw/svdundo.cxx
+++ b/svx/source/svdraw/svdundo.cxx
@@ -317,11 +317,6 @@ SdrUndoAttrObj::SdrUndoAttrObj(SdrObject& rNewObj, bool bStyleSheet1, bool 
bSave
 
     if(!bIsGroup || bIs3DScene)
     {
-        if(pUndoSet)
-        {
-            delete pUndoSet;
-        }
-
         pUndoSet = new SfxItemSet(pObj->GetMergedItemSet());
 
         if(bStyleSheet)

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.