Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index 

Hi all,

I'm not much familiar with perl, but I think the previous implementation of
build.pl had bugs.
For example, --skip option would always be rejected before 'next'
statement, because get_modules_passed() always returns nothing (evaluated
as false). As a result --skip would be incorrectly pushed to @dmake_args.
The same is true for other options, when rhs of assignment is something
evaluated as false (including "0" and '').

I also think it is not good behaviour to push options to @dmake_args when
it fails to parse.
However, I didn't fix it because that could possibly introduce incosistency
with existing scripts.

Cheers,

-- 
Daisuke Nishino

Attachment: 0001-Fix-bug-in-build.pl-option-parser.core.patch
Description: Binary data

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.