On Wed, 2011-10-26 at 19:49 +0200, Michael Stahl wrote:
On 26/10/11 18:55, Noel Power wrote:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=3fcb94311fd7dd40c05ca132e3a30a888316cbbe
..
have no clue when it comes to OLE automation, but after reading the bug
your patch looks like it could help and even if not it doesn't break
anything that isn't already broken :)
The code is similarly opaque to me :-) if you're happy it is tested and
works I don't know that we'll find any more competent reviewers. It is
slightly concerning to me that this method has seemingly been using a
SAFEARRAY since 2000:
commit 5840ee38df56933c54dcaaa6ec4e4ba01f173f6c
Author: Joachim Lingner <jl@openoffice.org>
Date: Thu Oct 12 12:15:53 2000 +0000
Sequences can now be converted into SAFEARRAYs of a specified type.
Sequence<Sequence<..>> etc. can be converted into SAFEARRAY with
multiple dimensions.
Which doesn't tally well with talk of this working in 3.2 and breaking
in 3.3 / 3.4 ... but if it improves life markedly and the users are
happy ... :-)
ATB,
Michael
--
michael.meeks@suse.com <><, Pseudo Engineer, itinerant idiot
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.