Re: [Libreoffice] [PUSHED] Fix for Bug fdo#41997 clean VCL enumeration

Hi Michael

Em 21-10-2011 17:51, Michael Meeks escreveu:
> Hi Olivier,
>
> On Fri, 2011-10-21 at 17:15 -0200, Olivier Hallot wrote:
> > The following patch fixes bug fdo41997.
> > https://bugs.freedesktop.org/show_bug.cgi?id=41997
>         Wow - no sooner than I filed it, it got closed :-) great work. I pushed
> the patch, it looks like you caught all the cases in mac / win32; any
> chance you can close the bug ?

Will do... I found bugzilla quite strange these days with big red banner 
each time I submit something...


>         If you had more time, cleaning up the whole enumeration to be VCL_
> prefixed would be nice too,

you mean prefix VCL_ to the remaining enumeration?
like
INPUT_PAINT
INPUT_MOUSEANDKEYBOARD
etc...?

I thought to do it, but did'nt dare to go beyond strict instructions (me 
quite shy).


>   and of course it'd be great to have a
> statement of MPL/LGPLv3+ for your patches linked at:
> http://wiki.documentfoundation.org/Development/Developers if you have a
> minute ?

Done. Let me know if this is enough.


>         Much appreciated though - it should make the Windows compile that bit
> nicer :-) [ have you tried setting up the MingW build ? it's
> particularly good for showing off these windows specific warnings - of
> which there are a large number :-]

This is for me "to go boldly where no man never went before"... but I 
don't have green blood or sharp ears, so i'll try.

>         Oh - and ! really great to see you in Paris, and hope you got back
> uneventfully ;-)

like any 11 hours flight in economy class... quite chewed.

Kind regards

--
Olivier Hallot
Founder, Steering Commitee Member - The Document Foundation
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812