Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Remember that char is either signed or unsigned, depending on
platform. Sure, char being signed is the much more common thing, but
for instance on ARM Linuxes it is unsigned. So code like:

char nDiff = bDown ? 1 : -1;
...
if( (-1 == nDiff && 0 >= nLevel) ||
     (1 == nDiff && MAXLEVEL - 1 <= nLevel))

is wrong. nDiff will never be -1.

One more reason to always build with --enable-werror.

--tml

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.