Re: [Libreoffice] memory leak or tricky LO foo?

Eike Rathke <ooo -AT- erack.de>

Wed, 19 Oct 2011 15:00:58 +0200

Hi Kevin, On Wednesday, 2011-10-05 02:01:24 -0400, Kevin Hunter wrote:

In idly reading LO code (trying yet again to spend time wrapping my
head around anything in the code base),

Great :)

I'm puzzled by this snippet
(with minor format alteration for email) from
svl/source/numbers/zforlist.cxx (currently around line 2226).  It
seems to me that pNewFormat is a memory leak, but I don't know the
LO well enough to state that. Specifically, is aFTable.Insert saving
the pointed to memory?

aFTable takes ownership of the pointer, hence the delete only after an unsuccessful Insert(). See SvNumberFormatter dtor where entries are deleted. Eike -- PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication. Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD

Attachment: signature.asc
Description: Digital signature

Context

[Libreoffice] memory leak or tricky LO foo? · Kevin Hunter

Re: [Libreoffice] memory leak or tricky LO foo? · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.