Re: [Libreoffice] [PATCH] Mark ecx register as clobbered (in cpp_uno/gcc3_macosx_intel)

On 10/15/2011 12:03 PM, Kristian Rietveld wrote:
> On 10/15/11 10:44 AM, Stephan Bergmann wrote:
> > On 10/15/2011 01:25 AM, Kristian Rietveld wrote:
> > > Without this patch, Cpp bridgetest on a Clang-compiled UNO runtime will
> > > not complete successfully.
> >
> > Hm, but the asm code in question does not use ecx at all?!?
>
> The asm code performs a call instruction and the called function does
> not have to preserve the contents of the ecx register, so ecx may have
> been overwritten when execution continues in this inline assembly after
> returning from the called function.

Yeah, embarrassedly smote my forehead when we talked about it (even more 
embarrassing as you already explained it in the commit comment, anyway). 
 Sorry for the noise.

Would like to push (incl. corresponding fix to the other affected x86 
bridges), but have problems contacting anongit.freedesktop.org right now...

Btw, if this is your first patch, please state what license it is 
under---preferably the LGPLv3+/MPL 1.1 combo---and add yourself to 
<http://wiki.documentfoundation.org/Development/Developers>.

Thanks again,
-Stephan