Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Has anybody had a chance to review this patch? I'm really interested
in writing some tests for basic and I'd like to make sure that these
types of changes are on the right track.

August Sodora
augsod@gmail.com
(201) 280-8138



On Tue, Oct 4, 2011 at 3:48 PM, August Sodora <augsod@gmail.com> wrote:
I've attached a revised patch that should fix the pLine issue. The
assignment to pLine is now redundant and all the checks in pLine can
probably be more appropriately expressed in terms of aLine anyway. I'm
not sure how ToUpperAscii affects this patch, do you mind explaining a
little further?

August Sodora
augsod@gmail.com
(201) 280-8138



On Tue, Oct 4, 2011 at 6:27 AM, Caolán McNamara <caolanm@redhat.com> wrote:
On Tue, 2011-10-04 at 10:57 +0200, Jan Holesovsky wrote:
BTW, another horror in the original code is:

ch1 = aSym.ToUpperAscii().GetBuffer()[0];

ie. we convert the entire string to upper case, and then throw all that
away but the first char.

[Byte]String::ToUpperAscii, see tools/source/string/strimp.cxx, modifies
the string it operates on and returns a reference to *this, i.e.

aSym = "hello";
aSym.ToUpperAscii();;
//aSym contains "HELLO" now

I mean, it doesn't return an uppercased copy, but returns itself, which
has been uppercased.

C.




Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.