Re: [Libreoffice] [PATCH], VALGRIND=memcheck => sc unit test discovered bug

On Thu, 2011-10-06 at 16:58 +0200, Markus Mohrhard wrote:
> Hello Caolan,
>
> 2011/10/6 Caolán McNamara <caolanm@redhat.com>
>         btw, in case people don't know you can
>         export VALGRIND=memcheck
>         make -sr
>         and the unit tests are run under valgrind then
>         
>         e.g. the sc unit test has the attached valgrind.log bug in it,
>         I've
>         attached a probable fix.
>
> You can blame me, I know it and I saw the problem in one of my ouputs
> but wrote it on my todo list because I was debugging a crash in the
> basic support.

Heh. Don't over-blame yourself for something you are not
responsible. ;-)  That's my code, so it's not yours to take heat for.

(Besides I don't believe in blame-fest.  We help each other out.)

> I'll have a look at the patch later.

The patch is perfectly fine.  You have my blessing.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc