Re: [Libreoffice] #ifdef ALPHA for DEC Alpha?

Hi Caolán, Tor, all,

Thank you for your advice.

On Fri, 30 Sep 2011 09:38:17 +0100, Caolán McNamara <caolanm@redhat.com> wrote:
> > I stumbled on some ifdefs of ALPHA existing as follows:
> > > sfx2/inc/sfx2/minarray.hxx:#if defined (ALPHA) && defined (UNX)
> > > svtools/source/filter/filter.cxx:#if defined UNX && defined ALPHA
> > > sw/source/core/docnode/ndsect.cxx:#if defined( ALPHA ) && defined( UNX )
> > > sw/source/core/docnode/node.cxx:#if defined( ALPHA ) && defined( UNX )
> > > sw/source/core/docnode/node.cxx:#if defined( ALPHA ) && defined( UNX )
> > > sw/source/core/table/swtable.cxx:#if defined(ALPHA) && defined(WNT)
> > > sw/source/core/table/swtable.cxx:#if defined(ALPHA) && defined(WNT)
> > > tools/source/stream/strmunx.cxx:#if defined(RS6000) || defined(ALPHA) || defined(NETBSD) || \
> > > tools/source/stream/strmunx.cxx:#if !defined(RS6000) && !defined(ALPHA) && !defined(NETBSD) && 
> > > !defined (FREEBSD) && \
>
> > but solenv/inc/unxlngaxp.mk does not define it nor somewhere else.
> > Should it be fixed or just removed?
>
> yeah, the Linux Alpha port defines "AXP" not "ALPHA", the "ALPHA" stuff
> can go.
Removed the above stuff now:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=6612ea7d9b03dc9cec1c98fdff0e1a22d2aab241
Anyway I have no Alpha to check the build, so try on machines of the
architecture would be greatly appreciated.

Cheers,
-- Takeshi Abe

> FWIW the scheme (for linux anyway) of the gbuild newer-style .mk, e.g.
> solenv/gbuild/platform/linux-ARCH.mk, implies a -DARCH of that ARCH
>
> C.