[Libreoffice] [REVIEW 3.4] fdo#35728 forms.OGridControlModel segfault

On Tue, 2011-09-27 at 13:58 +0200, Bjoern Michaelsen wrote:
> I found another patch that fell though the cracks:
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=a8d1349bf5d84fc7170a80813d4edcf562184d48

        Looks good to me too, but it seems we have something like this in 3-4
anyway:

void DbGridControl::RemoveColumn(sal_uInt16 nId)
{
    sal_uInt16 nIndex = GetModelColumnPos(nId);
    if (nIndex == GRID_COLUMN_NOT_FOUND)
        return;

        Which seems similar to the master version; do we need the appended
instead there ?

        Thanks,

                Michael.

--- a/svx/inc/svx/gridctrl.hxx
+++ b/svx/inc/svx/gridctrl.hxx
@@ -116,7 +116,7 @@ public:
     virtual void columnChanged() = 0;
 };
 
-#define GRID_COLUMN_NOT_FOUND   ((sal_uInt16)-1)
+#define GRID_COLUMN_NOT_FOUND   SAL_MAX_UINT16
 
 //==================================================================
 // InitWindowFacet, describing which aspect of a column's Window to (re-)initialize

-- 
michael.meeks@suse.com  <><, Pseudo Engineer, itinerant idiot