On Fri, 2011-09-23 at 22:36 +0400, Ivan Timofeev wrote:
2011/9/23 Caolán McNamara <caolanm@redhat.com>:
Looks sane to me. A good catch, pushed now.
He-he, I forgot to consider absolutely crazy cases - if
<mmultiscripts> element is empty at all. Should this be fixed?
Probably, can't ever be too safe on anything which is basically content
controlled by the outside world I suppose. There's always something that
manages to find its way through the logic cracks eventually. Pushed this
now.
In that vein
- if (rNodeStack.Count() == nElementCount)
+ if (rNodeStack.Count() <= nElementCount)
doesn't hurt either I think.
C.
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.